Keep httpEndpoint valid
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Fixes broken test options required for new test case.
rquitales
force-pushed
the
rquitales/fix-patches
branch
from
010711d
to
446fce3
Compare
rquitales
added
the
impact/no-changelog-required
iwahbe
requested changes
Aug 24, 2023
There was a problem hiding this comment.
This is very similar to what caused us problems in with aws.rds.Instance. Could we remove the patch all-together and apply a similar solution to pulumi/pulumi-aws#2686 (keeping all of our code in resources.go).
This way there won't be any unintended interactions within the upstream provider.
This is an alternative strategy to restore an old field, and does not require a patch in the upstream provider. Instead, we create the field in resources.go and make sure that if a user sets it, we move it to `restEndpoint` (which the provider still has as valid).
iwahbe
changed the title
httpEndpoint valid
iwahbe
approved these changes
Aug 25, 2023
guineveresaenger
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by re-projecting the field into the TF provider (without logic) and then ensuring that the upstream provider never sees the field. This fixes #181.
We also: