Fix IMDSv2 test to allow /tmp to be immutable #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2024
Merged
t0yv0
commented
Oct 26, 2024
| @@ -94,7 +94,7 @@ resources: | |||
| bucket: ${upload-bucket.id} | |||
| key: pulumi-resource-aws | |||
| source: | |||
| fn::FileAsset: ${localProviderBuild} | |||
| fn::fileAsset: ${localProviderBuild} | |||
There was a problem hiding this comment.
Removes a warning; the older form is obsolete.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
corymhall
approved these changes
Oct 28, 2024
flostadler
approved these changes
Oct 28, 2024
|
This PR has been shipped in release v6.57.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IMDSv2 test provisions a RC of the pulumi-aws-provider inside an AWS test account and checks if it can authenticate. Unfortunately something changed in the cloud that no longer permits unix programs to make changes to
/tmp. The test relied to this for no good reason; the updated version creates a dedicated folder /home/ec2-user/repro to perform the check.Fixes #4670