Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do make releases from -prerelease tags" #2679

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Aug 8, 2023

This reverts commit 2692e6e.

Per #2678 this did not work as expected but created incorrectly versioned releases.

@t0yv0 t0yv0 requested review from mikhailshilkov and a team August 8, 2023 12:14
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 requested a review from iwahbe August 10, 2023 13:18
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ok merging with failing tests

@t0yv0 t0yv0 merged commit 008c436 into master Aug 10, 2023
7 of 12 checks passed
@t0yv0 t0yv0 deleted the t0yv0/revert-prerelease-goreleaser-config-change branch August 10, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants