Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost descriptions #4588

Closed
t0yv0 opened this issue Oct 1, 2024 · 5 comments · Fixed by #4589
Closed

Lost descriptions #4588

t0yv0 opened this issue Oct 1, 2024 · 5 comments · Fixed by #4589
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 1, 2024

Describe what happened

It appears we lost resource descriptions from schema and registry

https://www.pulumi.com/registry/packages/aws/api-docs/iam/role/

I have noticed that running make tfgen adds descriptions to the checked-in schema.json.

This seems to be a very short description:

jq -r ".resources[\"aws:iam/role:Role\"].description" $(git ls-files "**schema.json")                                                                       

## Import

Using `pulumi import`, import IAM Roles using the `name`. For example:

```sh
$ pulumi import aws:iam/role:Role developer developer_name

There is a lot more information that used to be available.

Sample program

See above.

Log output

N/A

Affected Resource(s)

Presumably a lot of resources.

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 1, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 1, 2024

On 6.53.0 it had:

anton@anton-mbp-m3> jq -r ".resources[\"aws:iam/role:Role\"].description" $(git ls-files "**schema.json")   | head                                                                    ~/code/pulumi-aws2
Provides an IAM role.

> **NOTE:** If policies are attached to the role via the `aws.iam.PolicyAttachment` resource and you are modifying the role `name` or `path`, the `force_detach_policies` argument must be set to `true` and applied before attempting the operation otherwise you will encounter a `DeleteConflict` error. The `aws.iam.RolePolicyAttachment` resource (recommended) does not have this requirement.

> **NOTE:** If you use this resource's `managed_policy_arns` argument or `inline_policy` configuration blocks, this resource will take over exclusive management of the role's respective policy types (e.g., both policy types if both arguments are used). These arguments are incompatible with other ways of managing a role's policies, such as `aws.iam.PolicyAttachment`, `aws.iam.RolePolicyAttachment`, and `aws.iam.RolePolicy`. If you attempt to manage a role's policies by multiple means, you will get resource cycling and/or errors.

> **NOTE:** We suggest using explicit JSON encoding or `aws.iam.getPolicyDocument` when assigning a value to `policy`. They seamlessly translate configuration to JSON, enabling you to maintain consistency within your configuration without the need for context switches. Also, you can sidestep potential complications arising from formatting discrepancies, whitespace inconsistencies, and other nuances inherent to JSON.

## Example Usage

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 1, 2024

Looks like 6.54.0 regressed it. Looking.

@t0yv0 t0yv0 self-assigned this Oct 1, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 1, 2024

Looks like it's just scoped to aws.iam.Role. A bit surprising.

@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #4589 and shipped in release v6.54.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants