Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema.json out of sync causing registry breakage #1090

Open
t0yv0 opened this issue Oct 1, 2024 · 0 comments
Open

schema.json out of sync causing registry breakage #1090

t0yv0 opened this issue Oct 1, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 1, 2024 •
edited
Loading

Consider introducing CI checks making sure that the published schema.json for bridged providers is up-to-date.

Specifically:

  • run make tfgen on CI
  • see if this introduces edits to schema.json compared to the checked in version
  • fail the build if there are any edits

We need the generated schema.json to be up-to-date to what would be computed from the checked in inputs.

We seem to be missing such a check, causing this issue where registry descriptions for aws.iam.Role got wiped:

pulumi/pulumi-aws#4588

There might be alternative ways of fixing this by re-examining how registry is consuming schema.json from the bridged provider repo.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 1, 2024
@t0yv0 t0yv0 mentioned this issue Oct 1, 2024
Merged
t0yv0 added a commit to pulumi/pulumi-aws that referenced this issue Oct 1, 2024
@t0yv0
Re-generate schema to fix aws.iam.Role description (#4589)
13719db 
Fixes #4588

This simply a result of executing `make tfgen`. There is no impact on
SDKs its seems. There should be however impact on the registry.

This is a little un-intuitive but schema.json does not get reused for
SDK generation. Instead we have something like this:

```
schemaJson := tfgen("schema")
nodeSDK := tfgen("node")
javaSDK := tfgen("java")
```

It looks like CI is missing a check that re-generating schema.json with
`make tfgen` is a no-change operation, allowing this to drift and break
registry. Filing an issue in ci-mgmt.

pulumi/ci-mgmt#1090
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Oct 2, 2024
@mikhailshilkov mikhailshilkov added the kind/engineering Work that is not visible to an external user label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@t0yv0 @mikhailshilkov @VenelinMartinov @pulumi-bot