Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore stdlib #3

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Ignore stdlib #3

merged 2 commits into from
Feb 20, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Feb 19, 2024

This is a workaround for google/go-licenses#244.

Example PR is pulumi/pulumi-gitlab#507.

This is a workaround for google/go-licenses#244.
@iwahbe iwahbe self-assigned this Feb 19, 2024
iwahbe added a commit to pulumi/pulumi-gitlab that referenced this pull request Feb 19, 2024
@iwahbe iwahbe requested a review from a team February 19, 2024 10:55
@@ -20,6 +20,7 @@ runs:
# dependencies, but that doesn't occur when we're running against a raw checkout.
- run: |
go-licenses check ./... --ignore $(go list -m) --include_tests \
--ignore $(tr -d ' \n' <<<"${{ inputs.ignore-modules }}")
--ignore $(tr -d ' \n' <<<"${{ inputs.ignore-modules }}") \
--ignore $(go list std | awk 'NR > 1 { printf(",") } { printf("%s",$0) } END { print "" }')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would have been helpful here but people can git blame and check the PR, I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an explanatory comment.

@iwahbe iwahbe merged commit 39f7cef into main Feb 20, 2024
1 check passed
@iwahbe iwahbe deleted the iwahbe/ignore-stdlib branch February 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants