Skip to content

Commit

Permalink
test and cleanup submodule behavior (#15)
Browse files Browse the repository at this point in the history
* add devbox vscode extension

* specify git submodule for init and update
  • Loading branch information
usrbinkat authored Nov 13, 2023
1 parent 11e56dc commit 650197f
Show file tree
Hide file tree
Showing 4 changed files with 66 additions and 4 deletions.
63 changes: 63 additions & 0 deletions .devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
// Reference:
// - https://containers.dev/features
// - https://containers.dev/implementors/features
// - https://code.visualstudio.com/docs/getstarted/settings
{
// NOTE: remove `image` and uncomment `build` to build the image locally
//"build": {
// "dockerfile": "Dockerfile",
// "context": "."
//},
"name": "pulumi",
"image": "ghcr.io/pulumi/devcontainer",
"settings": {
"terminal.integrated.shell.linux": "/usr/bin/zsh"
},
"customizations": {
"vscode": {
"settings": [
"go.testTags", "all",
"go.buildTags", "all",
"editor.minimap.enabled", false,
"explorer.openEditors.visible", 1,
"editor.quickSuggestionsDelay", 0,
"editor.suggestSelection", "first",
"editor.snippetSuggestions", "top",
"editor.gotoLocation.multipleReferences", "goto",
"editor.gotoLocation.multipleDefinitions", "goto",
"editor.gotoLocation.multipleDeclarations", "goto",
"editor.gotoLocation.multipleImplementations", "goto",
"editor.gotoLocation.multipleTypeDefinitions", "goto",
"files.trimTrailingWhitespace", true,
"files.trimFinalNewlines", true
],
"extensions": [
"golang.go",
"vscodevim.vim",
"github.copilot",
"ms-python.python",
"jetpack-io.devbox",
"redhat.vscode-yaml",
"eg2.vscode-npm-script",
"esbenp.prettier-vscode",
"ms-vscode.makefile-tools",
"ms-azuretools.vscode-docker",
"github.vscode-pull-request-github",
"ms-vscode-remote.remote-containers",
"visualstudioexptteam.vscodeintellicode",
"bierner.markdown-preview-github-styles"
]
}
},
"features": {
"ghcr.io/devcontainers/features/common-utils:2": {},
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
"version": "latest",
"installDockerBuildx": true,
"moby": false
}
},
"postCreateCommand": "git submodule update --init --recursive",
"remoteUser": "vscode",
"runArgs": ["--network=host"]
}
1 change: 0 additions & 1 deletion .devcontainer/devcontainer.json

This file was deleted.

4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ To add this repository as a submodule to your project, run the following command

```bash
git submodule add https://github.com/pulumi/devcontainer .devcontainer
git submodule update --init --recursive
git submodule update --init --recursive .devcontainer
```

To update the devcontainer submodule in consuming repos:

```bash
git submodule update --remote --merge
git submodule update --remote --merge .devcontainer
```

After the submodule is added, you can open your project in VS Code and it will automatically detect the Dev Container configuration and prompt you to open the project in a container, or you can open the project in Github CodeSpaces.
Expand Down
2 changes: 1 addition & 1 deletion devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"golang.go",
"vscodevim.vim",
"github.copilot",
"eamodio.gitlens",
"ms-python.python",
"jetpack-io.devbox",
"redhat.vscode-yaml",
"eg2.vscode-npm-script",
"esbenp.prettier-vscode",
Expand Down

0 comments on commit 650197f

Please sign in to comment.