-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to remove actions hooks #1038
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -190,6 +190,16 @@ jobs: | |
| - name: Login to Google Cloud Registry | ||
| run: gcloud --quiet auth configure-docker | ||
| #{{- end }}# | ||
| #{{- if .Config.sshPrivateKey }}# | ||
| - name: Setup SSH key | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: #{{ .Config.sshPrivateKey }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Prepare upstream code | ||
| run: make upstream | ||
| #{{- end }}# | ||
| #{{- if index .Config "setup-script" }}# | ||
| - name: Run setup script | ||
| run: #{{ index .Config "setup-script" }}# | ||
|
|
@@ -204,9 +214,13 @@ jobs: | |
| #{{- if .Config.actions.preTest }}# | ||
| #{{ .Config.actions.preTest | toYaml | indent 4 }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Run provider tests | ||
| working-directory: provider | ||
| run: go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| #{{- end }}# | ||
| - name: Run tests | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ | ||
| matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,6 +103,16 @@ jobs: | |
| - name: Login to Google Cloud Registry | ||
| run: gcloud --quiet auth configure-docker | ||
| #{{- end }}# | ||
| #{{- if .Config.sshPrivateKey }}# | ||
| - name: Setup SSH key | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: #{{ .Config.sshPrivateKey }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Prepare upstream code | ||
| run: make upstream | ||
| #{{- end }}# | ||
| #{{- if index .Config "setup-script" }}# | ||
| - name: Run setup script | ||
| run: #{{ index .Config "setup-script" }}# | ||
|
|
@@ -117,6 +127,12 @@ jobs: | |
| #{{- if .Config.actions.preTest }}# | ||
| #{{ .Config.actions.preTest | toYaml | indent 4 }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Run provider tests | ||
| if: matrix.testTarget == 'local' | ||
| working-directory: provider | ||
| run: go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| #{{- end }}# | ||
| - name: Run tests | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ | ||
| matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -131,6 +131,16 @@ jobs: | |
| - name: Login to Google Cloud Registry | ||
| run: gcloud --quiet auth configure-docker | ||
| #{{- end }}# | ||
| #{{- if .Config.sshPrivateKey }}# | ||
| - name: Setup SSH key | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: #{{ .Config.sshPrivateKey }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Prepare upstream code | ||
| run: make upstream | ||
| #{{- end }}# | ||
| #{{- if index .Config "setup-script" }}# | ||
| - name: Run setup script | ||
| run: #{{ index .Config "setup-script" }}# | ||
|
|
@@ -145,9 +155,13 @@ jobs: | |
| #{{- if .Config.actions.preTest }}# | ||
| #{{ .Config.actions.preTest | toYaml | indent 4 }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Run provider tests | ||
| working-directory: provider | ||
| run: go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| #{{- end }}# | ||
| - name: Run tests | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ | ||
| matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,6 +130,16 @@ jobs: | |
| - name: Login to Google Cloud Registry | ||
| run: gcloud --quiet auth configure-docker | ||
| #{{- end }}# | ||
| #{{- if .Config.sshPrivateKey }}# | ||
| - name: Setup SSH key | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: #{{ .Config.sshPrivateKey }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Prepare upstream code | ||
| run: make upstream | ||
| #{{- end }}# | ||
| #{{- if index .Config "setup-script" }}# | ||
| - name: Run setup script | ||
| run: #{{ index .Config "setup-script" }}# | ||
|
|
@@ -144,9 +154,13 @@ jobs: | |
| #{{- if .Config.actions.preTest }}# | ||
| #{{ .Config.actions.preTest | toYaml | indent 4 }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Run provider tests | ||
| working-directory: provider | ||
| run: go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| #{{- end }}# | ||
| - name: Run tests | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ | ||
| matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -173,6 +173,16 @@ jobs: | |
| - name: Login to Google Cloud Registry | ||
| run: gcloud --quiet auth configure-docker | ||
| #{{- end }}# | ||
| #{{- if .Config.sshPrivateKey }}# | ||
| - name: Setup SSH key | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: #{{ .Config.sshPrivateKey }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Prepare upstream code | ||
| run: make upstream | ||
| #{{- end }}# | ||
| #{{- if index .Config "setup-script" }}# | ||
| - name: Run setup script | ||
| run: #{{ index .Config "setup-script" }}# | ||
|
|
@@ -187,10 +197,15 @@ jobs: | |
| #{{- if .Config.actions.preTest }}# | ||
| #{{ .Config.actions.preTest | toYaml | indent 4 }}# | ||
| #{{- end }}# | ||
| #{{- if .Config.integrationTestProvider }}# | ||
| - name: Run provider tests | ||
| if: matrix.testTarget == 'local' | ||
| working-directory: provider | ||
| run: go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| #{{- end }}# | ||
| - name: Run tests | ||
| if: matrix.testTarget == 'local' | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ | ||
| matrix.language }} -skip TestPulumiExamples -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt | ||
| - name: Run pulumi/examples tests | ||
| if: matrix.testTarget == 'pulumiExamples' | ||
| run: cd examples && go test -v -json -count=1 -cover -timeout 2h -tags=${{ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unit testing the provider, no?
It's natural for providers to have slightly different ways to test themselves (for example I think it's a mistake to assume the
providersubdiretory). Simplifying this to something likemake test_provider_ci(or whatever) could accomplish the same while still leaving the door open for some repo-specific behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is running the language-specific tests within the provider. I think these are basically all tests which depend on either the SDKs or having access to deploy test infrastructure. These are specified by tags such as
nodejssimilar to the examples. These tests are excluded from running by default when running the normal provider unit tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man I missed the language tag, that's weird! Is this maybe just an instance of someone dropping E2E tests under
providerinstead ofexamples?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - which is what we already have in a few providers. I think all the replay tests are in the provider folder, for example. This just formalises what's already being done into a simple option rather than leaning on providers to inject their own custom steps and matrix options.