Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract shared test workflows and action #1037

Draft
wants to merge 1 commit into
base: remove-actions-hooks
Choose a base branch
from

Commits on Jul 12, 2024

  1. Extract shared test workflows and action

    The "test" and "test examples" share most of their setup except for the actual test command to run so we can extract this into a "test-setup" composite action.
    
    Only the "run-acceptance-tests" workflow runs the example tests so we only call it from there. The main, prerelease and release workflows only call the main "test" workflow.
    
    Reorder the top-level workflow to be closer to the order of execution to make it easier to find the code when looking at an execution run.
    
    Remove explicit ref checkout during tests
    
    This ref isn't checked out for any other step so shouldn't be used here either.
    
    Remove left-over test-example condition
    
    We should be allowed to run this from other workflows. This condition is just needed within the run-acceptance-tests top-level workflow.
    
    Checkout before calling composite action
    
    The code has to be checked out to call a local action.
    
    Fix missing shells
    
    Add env for sub-workflows
    
    Fix secrets access in composite action
    
    Secrets are not available and must be passed as explicit inputs.
    
    This must also be fixed in any providers specifying arbitrary code in their actions.preTest ci-mgmt config.
    
    Always ensure upstream before tests
    
    This is hard-coded into lots of provider's preTest config.
    
    Fix missing token secret
    
    Only test examples if enabled
    
    Fix missing upstream shell
    
    Apply to nightly-test workflow
    danielrbradley committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ee91ccb View commit details
    Browse the repository at this point in the history