Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaf src #6

Open
wants to merge 20 commits into
base: machine-decaf-source
Choose a base branch
from
Open

Conversation

confused-Techie
Copy link
Member

@confused-Techie confused-Techie commented Jan 7, 2025

This PR keeps with our overall goal of removing CoffeeScript everywhere we find it.

In this PR I'll focus on the decaf work of the src directory, to ensure we don't attempt to decaf both the specs and source at the same time.

And keeping with our guidelines of decaf work, I've first created a branch machine-decaf-source which contains the pure unadulterated machine decaf work. Work we know will work without issue. Then in this branch manual-decaf-source are my changes to prettify and ensure the decafed code is usable.

This methodology allows easy review of my actual changes, with a smaller diff. If/when this PR is merged into machine-decaf-source then that branch will be merged into master without review to get our decaf work there.


Due to the way many classes are exported, this leaves a significant amount of formatting that needs to be changed, without any content changes. I'll do my best to keep formatting commits separate from content changes to provide the largest ease in review, if done commit by commit.


All source decaf work is done, the majority of the files haven't seen much change.
But the diffs of chunked-line-reader and path-filter are rather difficult to review.
This is because those files underwent significant reformatting after removing their initClass and syntax sugar around them.
For those two files I'd recommend looking at the commit history to see how they were modified instead.

@confused-Techie confused-Techie marked this pull request as draft January 7, 2025 02:07
@confused-Techie confused-Techie marked this pull request as ready for review January 7, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant