forked from atom/scandal
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decaf src
#6
Open
confused-Techie
wants to merge
20
commits into
machine-decaf-source
Choose a base branch
from
manual-decaf-source
base: machine-decaf-source
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Decaf src
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps with our overall goal of removing CoffeeScript everywhere we find it.
In this PR I'll focus on the decaf work of the
src
directory, to ensure we don't attempt to decaf both the specs and source at the same time.And keeping with our guidelines of decaf work, I've first created a branch
machine-decaf-source
which contains the pure unadulterated machine decaf work. Work we know will work without issue. Then in this branchmanual-decaf-source
are my changes to prettify and ensure the decafed code is usable.This methodology allows easy review of my actual changes, with a smaller diff. If/when this PR is merged into
machine-decaf-source
then that branch will be merged intomaster
without review to get our decaf work there.Due to the way many classes are exported, this leaves a significant amount of formatting that needs to be changed, without any content changes. I'll do my best to keep formatting commits separate from content changes to provide the largest ease in review, if done commit by commit.
All source decaf work is done, the majority of the files haven't seen much change.
But the diffs of
chunked-line-reader
andpath-filter
are rather difficult to review.This is because those files underwent significant reformatting after removing their
initClass
and syntax sugar around them.For those two files I'd recommend looking at the commit history to see how they were modified instead.