Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #2
Due to #2 and the usage of
yarn
being required for successfully building the repository, I've also migrated to ayarn.lock
file and removedpackage-lock.json
to ensure it's obvious which one we are using.The main meat of this PR and it's actual purpose though is to upgrade
git-utils
. The reason for this is two-fold:git-utils
.One copy is required by Pulsar itself at
[email protected]
and the other from this repositoryscandal
at[email protected]
. I'm hoping the differences in these versions have zero affect on scandal, considering how little of a version difference it is.But the reason this is important is in an unpacked ASAR archive:
[email protected]
:85.8MB
[email protected]
:85.1MB
Meaning if we sync the versions of this dependency between Pulsar and scandal we will be able to remove
85.1MB
off of our install size, which while not huge on it's own, this is by far our biggest single dependency. So would be the best starting point at trying to reduce our install size and duplicated dependencies.