Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump git-utils & Migrate to yarn #3

Closed
wants to merge 5 commits into from
Closed

Conversation

confused-Techie
Copy link
Member

This PR requires #2

Due to #2 and the usage of yarn being required for successfully building the repository, I've also migrated to a yarn.lock file and removed package-lock.json to ensure it's obvious which one we are using.


The main meat of this PR and it's actual purpose though is to upgrade git-utils. The reason for this is two-fold:

  • Obviously upgrading dependencies is always a good thing when it's non-breaking.
  • More importantly, and the reason for doing this is looking at our unpacked ASAR archive of an installed Pulsar shows that we have two copies of git-utils.

One copy is required by Pulsar itself at [email protected] and the other from this repository scandal at [email protected]. I'm hoping the differences in these versions have zero affect on scandal, considering how little of a version difference it is.

But the reason this is important is in an unpacked ASAR archive:

Meaning if we sync the versions of this dependency between Pulsar and scandal we will be able to remove 85.1MB off of our install size, which while not huge on it's own, this is by far our biggest single dependency. So would be the best starting point at trying to reduce our install size and duplicated dependencies.

@DeeDeeG
Copy link
Member

DeeDeeG commented Jan 6, 2025

Interesting. I found that updating git-utils is required, as the outdated [email protected] doesn't compile against Node 16. So, this PR's changes and #2 should ideally be done in one PR, I guess.

Or else do one PR that flips CI on (possibly failing/red CI if done first) and another PR that gets us newer git-utils.

But I think doing both is necessary to have working CI for this repo, perhaps slightly ironically.

@confused-Techie
Copy link
Member Author

Replaced by #5

@confused-Techie confused-Techie deleted the bump-git-utils branch January 7, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants