-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jasmine to 2.x (one packages first) #1089
base: master
Are you sure you want to change the base?
Conversation
Pro: * Less code to maintain & update * run-package-tests was unused Con: * Lost the formatting
Pro: * Less code to maintain
…ored jasmine * only the vendored version got used during the tests * don't need to require jasmine multiple times Clean up vendored jasmine to make it easier to upgrade Remove checks about global jasmine as we're not setting it anymore
Co-authored-by: Andrew Dupont <[email protected]>
While I haven't dived into this yet, I truly appreciate your grace in understanding the difficulties of reviewing the larger PRs. Obviously I wish we could review and merge your initial one, baby steps may be the best way to move things forward. And I'm more than happy to take a look at this one, but of course would want to lean on @savetheclocktower's pretty expert view at finding the choke points that will bit us later. Although if this is all based off your previous work, it's possible you two have already ironed that out |
I put this one on the back burner for the reasons explained here, but I'm on a newer laptop these days and should try again. Thanks for opening this PR; I'll get to it when I can. |
I have a feeling that my other PR (#990) is too big to be reviewed easily with its +3k/-3k line change, so I had the idea of making it more incremental with smaller chunks of code. Of course, in the end we will need to merge that too, but let's see what can we achieve this way.
This time I only included the refactoring around the runners, but kept the atom-core on the old,
reliablejasmine1 runner. There's only one package I switched over to the new jasmine2, it's thearchive-view
package with only 21 test cases. Baby steps for achievable goals 😄I've run the package specs both in a non-headless mode and from the terminal, had no problems on Linux.