Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump node-gyp to latest ^10.2.0 for Python 3.12 compat #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,14 @@ jobs:
run: python3 -m pip install setuptools

- name: Install dependencies
if: ${{ matrix.node_version != 14 }}
run: yarn install

- name: Install dependencies (NodeJS v14)
# node-gyp v10+'s `engines` field dropped support for Node 14... Ignore and install anyway.
if: ${{ matrix.node_version == 14 }}
run: yarn install --ignore-engines

- if: "!contains(matrix.os, 'windows')"
name: Run tests 👩🏾‍💻
run: ./bin/npm test
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,14 @@
"coffee-script": "^1.12.7",
"express": "^4.17.1",
"jasmine-focused": ">=1.0.7 <2.0",
"node-gyp": "https://github.com/nodejs/node-gyp/archive/d3615c66f7e7a65de48ce9860b1fe13710d20988.tar.gz",
"node-gyp": "^10.2.0",
"shx": "^0.3.3"
},
"resolutions": {
"make-fetch-happen/**/ip": "^1.1.9",
"npm/**/got": "^11.8.6",
"npm/**/http-cache-semantics": "^4.1.1",
"npm/**/node-gyp": "^10.2.0",
"npm/**/tar": "^6.1.2"
}
}
Loading
Loading