Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate #110

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Configure Renovate #110

merged 4 commits into from
Dec 16, 2023

Conversation

confused-Techie
Copy link
Member

Added a Renovate configuration similar to the one currently used over on the Pulsar repo.

This will help us stay more on top of the dependencies within this repo automatically.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to think about this one for a tad, since if we actually use this, it could cause quite a bit of traffic around these parts where it's normally pretty slow. I want to think over an be comfortable with how it's going to proceed.

I had some specific thoughts on parts of the config in individual code comments in this thread.

The "node <15" thing I think is a valid suggestion on my part based on this example from the Renovate docs: https://docs.renovatebot.com/configuration-options/#constraints

But if this is how we're doing it in core, kinda makes sense to keep it consistent. If I have a chance to think this over for a bit that'd be great, but wanted to comment on this sooner rather than later just to be clear I wasn't ignoring it, since I've been reviewing everything else here very timely.

P.S. I read these docs to understand the config file, for anyone else curious about what these values all mean: https://docs.renovatebot.com/configuration-options (It was kind of hard to find this, IMO!)

.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Show resolved Hide resolved
.github/renovate.json Outdated Show resolved Hide resolved
@DeeDeeG
Copy link
Member

DeeDeeG commented Dec 16, 2023

I lean toward: have a dashboard, but separate the packages out to individual lines so we can see what version it wants to bump to.

And comments above to make the "informational view" the most useful as a guide when looking it over and bumping things manually.

@confused-Techie
Copy link
Member Author

@DeeDeeG Alright, I've taken all of your suggestions.

The dashboard has zero grouping, so we can view each dep individually, even as far as not splitting major minor or anything, so that we get as many different options as possible

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this feedback.

This works well for me as it's set up now (mostly using defaults, I suppose.)

I wasn't planning to include this in the ppm bump in core, since it's not a code change more of a meta thing, won't affect users in and of itself, but I might as well include it if we do get this in before I do the ppm bump PR. 🤷

Anyway, THANK YOU for all the attention given to this repo lately, it's setting us up to do more good things here, for sure.

@confused-Techie
Copy link
Member Author

Fantastic, lets get it merged in then anyway, but like you said doesn't make much of a difference.

But I'm glad the focus is noticed, thought with those huge blockers out of the way like decaf and async, nows the time to shine on every other change that might be needed or wanted. So hopefully we can get things much more streamlined here

@confused-Techie confused-Techie merged commit 5d219f7 into master Dec 16, 2023
11 checks passed
@confused-Techie confused-Techie deleted the configure-renovate branch December 16, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants