Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune outdated Deps #109

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Prune outdated Deps #109

merged 1 commit into from
Dec 15, 2023

Conversation

confused-Techie
Copy link
Member

After all the recent modifications and updates in this repo, seemed to be a good idea to make sure we didn't have any old useless deps lying around.

Was able to find a few that are no longer in use:

  • glob
  • q
  • coffeelint

DeeDeeG
DeeDeeG approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me! (Tests passing.)

Linking to the other PR where we identified coffeelint should eventually be removed as a follow-up task at the time: #92

Great to prune these un-needed deps!

@DeeDeeG
Copy link
Member

DeeDeeG commented Dec 15, 2023

Going to merge this one myself, very straightforward PR.

@DeeDeeG DeeDeeG merged commit 13c3518 into master Dec 15, 2023
11 checks passed
@DeeDeeG DeeDeeG mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeeDeeG DeeDeeG DeeDeeG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@confused-Techie @DeeDeeG