Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Newer NodeJS CI #106

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix Newer NodeJS CI #106

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e84a602
Manually install python and `setuptools`
confused-Techie Dec 13, 2023
ab0e38b
Continue default behavior for NodeJS v14
confused-Techie Dec 13, 2023
8a65396
Manual Python install for all CI
confused-Techie Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,28 @@ jobs:
architecture: ${{ matrix.node_arch }}
check-latest: true

- name: Setup Python
# NodeJS v14 can use the python included by the CI
if: ${{ matrix.node_version != 14 }}
uses: actions/setup-python@v4
with:
python-version: '3.12'

- name: Setup Python (NodeJS v14)
# While initially tests would pass with no Python setup, additional testing
# is showing issues with CI included Python versions, so we will install our own
if: ${{ matrix.node_version == 14 }}
uses: actions/setup-python@v4
with:
python-version: '3.10'

- name: Install Python Dependencies
# NodeJS v14 doesn't have a newer copy of python, so we don't need to install deps
if: ${{ matrix.node_version != 14 }}
# This is needed for Python 3.12+, since node-gyp requires
# 'distutils', which has been removed
run: python3 -m pip install setuptools

- name: Install dependencies
run: |
# Yarn v1.x needs global node-gyp available if npm 9.7.2+ is the global npm version,
Expand Down