Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Fix usage/help text (and error message) for -b/-t flags for ppm install #105

Merged
merged 2 commits into from
Dec 14, 2023
Merged

src: Fix usage/help text (and error message) for -b/-t flags for ppm install #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5005436
src: Fix usage/help text for -b/-t flags for ppm install
DeeDeeG Dec 13, 2023
ad9d31a
src: Update error text for -b/-t flags in install.js
DeeDeeG Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ class Install extends Command {

Usage: ppm install [<package_name>...]
ppm install <package_name>@<package_version>
ppm install <git_remote> [-b <branch_or_tag_or_commit>]
ppm install <github_username>/<github_project> [-b <branch_or_tag_or_commit>]
ppm install <git_remote> [-b <branch_or_tag>]
ppm install <github_username>/<github_project> [-b <branch_or_tag>]
ppm install --packages-file my-packages.txt
ppm i (with any of the previous argument usage)

Expand Down Expand Up @@ -565,7 +565,7 @@ Run ppm -v after installing Git to see what version has been detected.\
const repo = Git.open(cloneDir);
data.sha = version;
const checked = repo.checkoutRef(`refs/tags/${version}`, false) || repo.checkoutReference(version, false);
if (!checked) { throw `Can't find the branch, tag, or commit referenced by ${version}`; }
if (!checked) { throw `Can't find the branch or tag referenced by ${version}`; }
} else {
const sha = this.getRepositoryHeadSha(cloneDir);
data.sha = sha;
Expand Down
Loading