Merge pull request #103 from pulsar-edit/stop-pinging-backend-for-uni…

…nstalls

src: Stop pinging backend during package uninstalls

src/uninstall.js

@@ -5,11 +5,9 @@ const async = require('async');
 const CSON = require('season');
 const yargs = require('yargs');
 
-const auth = require('./auth');
 const Command = require('./command');
 const config = require('./apm');
 const fs = require('./fs');
-const request = require('./request');
 
 module.exports =
 class Uninstall extends Command {
@@ -37,24 +35,6 @@ Delete the installed package(s) from the ~/.pulsar/packages directory.\
       }
     }
 
-    async registerUninstall({packageName, packageVersion}) {
-      if (!packageVersion) { return; }
-
-      try {
-        const token = await auth.getToken();
-        const requestOptions = {
-          url: `${config.getAtomPackagesUrl()}/${packageName}/versions/${packageVersion}/events/uninstall`,
-          json: true,
-          headers: {
-            authorization: token
-          }
-        };
-        return new Promise((resolve, _reject) => void request.post(requestOptions, (_error, _response, _body) => resolve()));
-      } catch (error) {
-        return error; // error as value here
-      }
-    }
-
     async run(options) {
       options = this.parseOptions(options.commandArgs);
       const packageNames = this.packageNamesFromArgv(options.argv);
@@ -66,7 +46,6 @@ Delete the installed package(s) from the ~/.pulsar/packages directory.\
       const packagesDirectory = path.join(config.getAtomDirectory(), 'packages');
       const devPackagesDirectory = path.join(config.getAtomDirectory(), 'dev', 'packages');
 
-      const uninstallsToRegister = [];
       let uninstallError = null;
 
       for (let packageName of Array.from(packageNames)) {
@@ -82,9 +61,6 @@ Delete the installed package(s) from the ~/.pulsar/packages directory.\
             if (fs.existsSync(packageManifestPath)) {
               const packageVersion = this.getPackageVersion(packageDirectory);
               fs.removeSync(packageDirectory);
-              if (packageVersion) {
-                uninstallsToRegister.push({packageName, packageVersion});
-              }
             } else if (!options.argv.hard) {
               throw new Error(`No package.json found at ${packageManifestPath}`);
             }
@@ -107,7 +83,6 @@ Delete the installed package(s) from the ~/.pulsar/packages directory.\
         }
       }
 
-      await async.eachSeries(uninstallsToRegister, (data, errorHandler) =>void this.registerUninstall(data).then(errorHandler));
       return uninstallError; // both error and lack of error, as return value atm
     }
   }