Eliminating the promiseBased setting of commands

Now that everything is Promise-based (and anything new should also be), it's
pointless to keep an option for classes to avoid wrapping into Promises.
Nothing should be wrapped anymore.

src/apm-cli.js

@@ -264,9 +264,6 @@ module.exports = {
         return errorHandler();
       } else if ((Command = commands[command])) {
         const command = new Command();
-        if (!Command.promiseBased) {
-          command.run = promisifiedRun(command.run);
-        }
         return command.run(options).then(errorHandler);
       } else {
         return errorHandler(`Unrecognized command: ${command}`);

src/ci.js

@@ -10,7 +10,6 @@ const Command = require('./command');
 
 module.exports =
 class Ci extends Command {
-  static promiseBased = true;
   static commandNames = ["ci"];
 
   constructor() {

src/clean.js

@@ -13,7 +13,6 @@ const fs = require('./fs');
 
 module.exports =
 class Clean extends Command {
-  static promiseBased = true;
   static commandNames = ["clean", "prune"];
 
   constructor() {

src/config.js

@@ -7,7 +7,6 @@ const Command = require('./command');
 
 module.exports =
 class Config extends Command {
-  static promiseBased = true;
   static commandNames = [ "config" ];
 
   constructor() {

src/dedupe.js

@@ -11,7 +11,6 @@ const fs = require('./fs');
 
 module.exports =
 class Dedupe extends Command {
-  static promiseBased = true;
   static commandNames = [ "dedupe" ];
 
     constructor() {

src/develop.js

@@ -15,7 +15,6 @@ const request = require('./request');
 
 module.exports =
 class Develop extends Command {
-  static promiseBased = true;
   static commandNames = [ "dev", "develop" ];
 
     constructor() {

src/disable.js

@@ -10,7 +10,6 @@ const List = require('./list');
 
 module.exports =
 class Disable extends Command {
-  static promiseBased = true;
   static commandNames = [ "disable" ];
 
     parseOptions(argv) {

src/docs.js

@@ -7,7 +7,6 @@ const config = require('./apm');
 
 module.exports =
 class Docs extends View {
-  static promiseBased = true;
   static commandNames = [ "docs", "home", "open" ];
 
     parseOptions(argv) {

src/enable.js

@@ -9,7 +9,6 @@ const Command = require('./command');
 
 module.exports =
 class Enable extends Command {
-  static promiseBased = true;
   static commandNames = [ "enable" ];
 
     parseOptions(argv) {

src/featured.js

@@ -9,7 +9,6 @@ const tree = require('./tree');
 
 module.exports =
 class Featured extends Command {
-  static promiseBased = true;
   static commandNames = [ "featured" ];
 
     parseOptions(argv) {

src/init.js

@@ -8,7 +8,6 @@ const fs = require('./fs');
 
 module.exports =
 class Init extends Command {
-  static promiseBased = true;
   static commandNames = [ "init" ];
 
   constructor() {

src/install.js

@@ -20,7 +20,6 @@ const {isDeprecatedPackage} = require('./deprecated-packages');
 
 module.exports =
 class Install extends Command {
-  static promiseBased = true;
   static commandNames = [ "install", "i" ];
 
     constructor() {

src/link.js

@@ -10,7 +10,6 @@ const fs = require('./fs');
 
 module.exports =
 class Link extends Command {
-  static promiseBased = true;
   static commandNames = [ "link", "ln" ];
 
     parseOptions(argv) {

src/links.js

@@ -10,7 +10,6 @@ const tree = require('./tree');
 
 module.exports =
 class Links extends Command {
-  static promiseBased = true;
   static commandNames = [ "linked", "links", "lns" ];
 
     constructor() {

src/list.js

@@ -13,7 +13,6 @@ const {getRepository} = require("./packages");
 
 module.exports =
 class List extends Command {
-  static promiseBased = true;
   static commandNames = [ "list", "ls" ];
 
     constructor() {

src/login.js

@@ -9,7 +9,6 @@ const Command = require('./command');
 
 module.exports =
 class Login extends Command {
-  static promiseBased = true;
   static commandNames = [ "login" ];
 
     static async getTokenOrLogin() {

src/publish.js

@@ -15,7 +15,6 @@ const request = require('./request');
 
 module.exports =
 class Publish extends Command {
-  static promiseBased = true;
   static commandNames = [ "publish" ];
 
     constructor() {

src/rebuild-module-cache.js

@@ -8,7 +8,6 @@ const fs = require('./fs');
 
 module.exports =
 class RebuildModuleCache extends Command {
-  static promiseBased = true;
   static commandNames = [ "rebuild-module-cache" ];
 
     constructor() {

src/rebuild.js

@@ -10,7 +10,6 @@ const fs = require('./fs');
 
 module.exports =
 class Rebuild extends Command {
-  static promiseBased = true;
   static commandNames = [ "rebuild" ];
 
     constructor() {

src/search.js

@@ -10,7 +10,6 @@ const {isDeprecatedPackage} = require('./deprecated-packages');
 
 module.exports =
 class Search extends Command {
-  static promiseBased = true;
   static commandNames = [ "search" ];
 
 

src/star.js

@@ -15,7 +15,6 @@ const request = require('./request');
 
 module.exports =
 class Star extends Command {
-  static promiseBased = true;
   static commandNames = [ "star" ];
 
     parseOptions(argv) {

src/stars.js

@@ -11,7 +11,6 @@ const tree = require('./tree');
 
 module.exports =
 class Stars extends Command {
-  static promiseBased = true;
   static commandNames = [ "stars", "starred" ];
 
     parseOptions(argv) {

src/test.js

@@ -9,7 +9,6 @@ const fs = require('./fs');
 
 module.exports =
 class Test extends Command {
-  static promiseBased = true;
   static commandNames = [ "test" ];
 
     parseOptions(argv) {

src/uninstall.js

@@ -13,7 +13,6 @@ const request = require('./request');
 
 module.exports =
 class Uninstall extends Command {
-  static promiseBased = true;
   static commandNames = [ "deinstall", "delete", "erase", "remove", "rm", "uninstall" ];
 
     parseOptions(argv) {

src/unlink.js

@@ -10,7 +10,6 @@ const fs = require('./fs');
 
 module.exports =
 class Unlink extends Command {
-  static promiseBased = true;
   static commandNames = [ "unlink" ];
 
     constructor() {

src/unpublish.js

@@ -12,7 +12,6 @@ const request = require('./request');
 
 module.exports =
 class Unpublish extends Command {
-  static promiseBased = true;
   static commandNames = [ "unpublish" ];
 
     parseOptions(argv) {

src/unstar.js

@@ -9,7 +9,6 @@ const request = require('./request');
 
 module.exports =
 class Unstar extends Command {
-  static promiseBased = true;
   static commandNames = [ "unstar" ];
 
     parseOptions(argv) {

src/upgrade.js

@@ -19,7 +19,6 @@ const git = require('./git');
 
 module.exports =
 class Upgrade extends Command {
-  static promiseBased = true;
   static commandNames = [ "upgrade", "outdated", "update" ];
 
     constructor() {

src/view.js

@@ -10,7 +10,6 @@ const tree = require('./tree');
 
 module.exports =
 class View extends Command {
-  static promiseBased = true;
   static commandNames = [ "view", "show" ];
 
     parseOptions(argv) {