Ignore tokens and keys in examples #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggainey
requested changes
Jul 29, 2024
.gitleaks.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [allowlist] | |||
| description = "Our test install exports a test only MINIO ACCESS KEY" | |||
| paths = [ | |||
| files = [ | |||
There was a problem hiding this comment.
Needs to stay "paths" - "files" is for specific-filenames (and is going to be deprecated soon anyway)
.gitleaks.toml
Outdated
| ".github/workflows/scripts/install.sh", | ||
| "docs/workflows/authentication.rst", |
There was a problem hiding this comment.
I think in this specific case, we're better served with a regexes = [ exact-key-here ] entry for the not-a-secret itself. Esp since this file is in history-only and won't be modifying the key ever again...
|
Note for future investigators - the token in question is an example of a temporary token generated by pulp - it's never been able to give access to anything other than the transient test system that originally generated it. |
lubosmj
force-pushed
the
lubosmj-patch-gitleaks-token
branch
3 times, most recently
from
3f1182a
to
8794975
Compare
Even though these files have been already deprecated, some checkers still care about older branches. [noissue]
lubosmj
force-pushed
the
lubosmj-patch-gitleaks-token
branch
from
8794975
to
5ef9e61
Compare
lubosmj
changed the title
ggainey
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though these files have been already deprecated, some checkers still care about older branches.
[noissue]