-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backward compatibility for manifest with artifact #1644
base: main
Are you sure you want to change the base?
Remove backward compatibility for manifest with artifact #1644
Conversation
160eb27
to
7f516b4
Compare
Have you considered returning pulp_container/pulp_container/app/registry_api.py Line 1083 in 81e5f11
return Response(manifest.data) .
|
83af4f4
to
0657cbb
Compare
I think tests are failing because of the caching machinery:
We started returning
|
@lubosmj If I understand correctly, before we started returning |
Oh, actually, the issue is that we cannot access |
@@ -1084,7 +1084,7 @@ def handle_safe_method(self, request, path, pk): | |||
else: | |||
raise ManifestNotFound(reference=pk) | |||
|
|||
return redirects.issue_manifest_redirect(manifest) | |||
return Response(manifest.data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bear in mind that we would like to return headers as well, similarly to return web.Response(text=tag.tagged_manifest.data, headers=response_headers)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lubosmj What headers would you like to return in this case?
Do you mind reverting the following changes?
I think we can get rid of them now. |
0657cbb
to
a2e7a53
Compare
This commit removes support for manifests storing their data inside an artifact instead of using the recently introduced Manifest.data text field. closes pulp#1621
a2e7a53
to
ed8bdf6
Compare
The work on this can be resumed now. |
This commit removes support for manifests storing their data inside an artifact instead of using the recently introduced Manifest.data text field.
closes #1621