-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[passenger] enable systemd #5494
base: main
Are you sure you want to change the base?
Conversation
8c3fb56
to
786341c
Compare
8dee03a
to
7a433de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a few questions, below.
It might also be easier to review this PR if you separate out the lint changes into their own PR?
358ccad
to
ed2e52b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a big PR, but seems ok to me. Just a couple small changes requested.
I wouldn't mind breaking the node changes out into a separate PR if you were ok with that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I'm seeing this looks good, but I am not confident that I understand the changes to Postgres and Yarn well enough to merge it based purely on my review.
Thanks for doing this @kayiwa!
what happens if this is run on a machine that had nodejs and redis already installed |
is anyone relying on the old default nodejs |
add sandbox-fkayiwa1 to figgy staging and run from main then run from this branch |
7185248
to
b064aa7
Compare
modify the molecule yaml file the command tells the container that systemd should be run as PID1 the tmp directories ensure that systemd has writeable directories remove the notest flag on the passenger role closes #1926
include all rails_app dependent applications
redis fails with gpg needed for keys. adding the common role addresses this
the redia ppa is no longer available
the preferred install method for yarn is corepack this installs yarn via shell commands
rasterio needs Cython to compile dependencies
make sure our molecule playbook matches the container temp directory for ansible
add tests for dss
use ansible verifier for molecule tests
1312600
to
595d953
Compare
modify the molecule yaml file in the example and the passenger role
the command tells the container that systemd should be run as PID1
the tmp directories ensure that systemd has writeable directories
remove the notest flag on the passenger role
closes #1926