Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[passenger] enable systemd #5494

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

kayiwa
Copy link
Member

@kayiwa kayiwa commented Oct 31, 2024

modify the molecule yaml file in the example and the passenger role
the command tells the container that systemd should be run as PID1
the tmp directories ensure that systemd has writeable directories

remove the notest flag on the passenger role

closes #1926

@kayiwa kayiwa requested a review from tpendragon October 31, 2024 13:32
@kayiwa kayiwa force-pushed the i1926_create_multiarch_systemd branch 3 times, most recently from 8c3fb56 to 786341c Compare October 31, 2024 14:51
@kayiwa kayiwa marked this pull request as draft October 31, 2024 15:18
@kayiwa kayiwa force-pushed the i1926_create_multiarch_systemd branch 25 times, most recently from 8dee03a to 7a433de Compare November 3, 2024 13:46
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few questions, below.

It might also be easier to review this PR if you separate out the lint changes into their own PR?

roles/dss/molecule/default/molecule.yml Outdated Show resolved Hide resolved
roles/figgy/tasks/main.yml Outdated Show resolved Hide resolved
roles/nodejs/molecule/default/verify.yml Show resolved Hide resolved
@kayiwa kayiwa force-pushed the i1926_create_multiarch_systemd branch from 358ccad to ed2e52b Compare November 4, 2024 14:47
Copy link
Member

@carolyncole carolyncole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big PR, but seems ok to me. Just a couple small changes requested.

I wouldn't mind breaking the node changes out into a separate PR if you were ok with that...

roles/blacklight_app/tasks/main.yml Outdated Show resolved Hide resolved
roles/dss/molecule/default/converge.yml Outdated Show resolved Hide resolved
roles/nodejs/defaults/main.yml Show resolved Hide resolved
roles/postgresql/tasks/main.yml Show resolved Hide resolved
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I'm seeing this looks good, but I am not confident that I understand the changes to Postgres and Yarn well enough to merge it based purely on my review.

Thanks for doing this @kayiwa!

@kayiwa
Copy link
Member Author

kayiwa commented Nov 4, 2024

what happens if this is run on a machine that had nodejs and redis already installed

@kayiwa
Copy link
Member Author

kayiwa commented Nov 4, 2024

is anyone relying on the old default nodejs

@kayiwa
Copy link
Member Author

kayiwa commented Nov 4, 2024

add sandbox-fkayiwa1 to figgy staging and run from main then run from this branch

@kayiwa kayiwa force-pushed the i1926_create_multiarch_systemd branch 2 times, most recently from 7185248 to b064aa7 Compare November 9, 2024 00:49
@kayiwa kayiwa requested a review from carolyncole November 9, 2024 01:14
kayiwa and others added 17 commits November 13, 2024 08:11
modify the molecule yaml file
the command tells the container that systemd should be run as PID1
the tmp directories ensure that systemd has writeable directories

remove the notest flag on the passenger role

closes #1926
include all rails_app dependent applications
redis fails with gpg needed for keys.
adding the common role addresses this
the redia ppa is no longer available
the preferred install method for yarn is corepack
this installs yarn via shell commands
rasterio needs Cython to compile dependencies
an endpoint is expected to have cron
make sure our molecule playbook matches the container temp directory for
ansible
add tests for dss
use ansible verifier for molecule tests
@kayiwa kayiwa force-pushed the i1926_create_multiarch_systemd branch from 1312600 to 595d953 Compare November 13, 2024 13:11
@kayiwa kayiwa marked this pull request as draft January 13, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can we introduce systemd tests
4 participants