Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use sidekiq as email delivery queue" #4702

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Revert "Use sidekiq as email delivery queue" #4702

merged 1 commit into from
Jan 14, 2025

Conversation

sandbergja
Copy link
Member

Reverts #4700

It seems that we will need to refactor much of requests emailing to pass in simpler, more sidekiq-compatible classes, we can reopen this then.

maxkadel
maxkadel approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja

@maxkadel maxkadel merged commit 0220cf1 into main Jan 14, 2025
13 checks passed
@maxkadel maxkadel deleted the revert-4700-sidekiq-email branch January 14, 2025 20:14
@coveralls
Copy link

Coverage Status

coverage: 95.799%. remained the same
when pulling 02a614d on revert-4700-sidekiq-email
into bcab118 on main.

@sandbergja sandbergja mentioned this pull request Jan 16, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkadel maxkadel maxkadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandbergja @coveralls @maxkadel