Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sidekiq as email delivery queue #4700

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Use sidekiq as email delivery queue #4700

merged 1 commit into from
Jan 14, 2025

Conversation

sandbergja
Copy link
Member

Also, put all indexers in an indexer capistrano role

closes #4609

Also, put all indexers in an indexer capistrano role

Co-authored-by: Max Kadel <[email protected]>
@@ -22,7 +22,7 @@ services:
type: postgres:15
portforward: true
orangelight_redis:
type: redis:6.0.16
type: redis:7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the redis version we use in prod

Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja @maxkadel 🍄 🦄 !

@coveralls
Copy link

Coverage Status

coverage: 95.783% (-0.02%) from 95.799%
when pulling 1647bbd on sidekiq-email
into 05b1e2b on main.

@sandbergja sandbergja merged commit 4a11226 into main Jan 14, 2025
14 checks passed
@sandbergja sandbergja deleted the sidekiq-email branch January 14, 2025 17:22
sandbergja added a commit to pulibrary/princeton_ansible that referenced this pull request Jan 14, 2025
After pulibrary/orangelight#4700, we will send
emails from a queue on the indexers, rather than directly on the web
servers.  To do this, we need to include those indexers in the allowlist
kevinreiss pushed a commit to pulibrary/princeton_ansible that referenced this pull request Jan 14, 2025
After pulibrary/orangelight#4700, we will send
emails from a queue on the indexers, rather than directly on the web
servers.  To do this, we need to include those indexers in the allowlist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SideKiq for email ActiveJob queues
3 participants