Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about upgrading components that emit events #123

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add a note about upgrading components that emit events #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ to the `<style>` section. You may also need `../assets/styles/spacing.scss` if
component uses spacing mixins. Media queries can't be included in CSS variables, so if you need those, import `../assets/styles/media_queries.scss` and use SCSS variables. There are functions that use SCSS variables and cannot take CSS variables as a parameter; In this case add `@import ../assets/styles/system.scss`.
1. Vue 3 no longer supports functional templates. If the component includes `<template functional>`,
you will need to refactor it back into a regular template.
1. If the component emits events, [declare the emits in the `emits` option](https://v3-migration.vuejs.org/breaking-changes/emits-option.html).
1. Run `npm run styleguide` and make sure it compiles and looks good.
1. Add the component to src/components/index.js so it is added to the lux Vue plugin and can be used in other projects.
1. Copy the test for the component from the lux test/unit/specs/components directory.
Expand Down
Loading