Skip to content

Commit

Permalink
Add a note about upgrading components that emit events
Browse files Browse the repository at this point in the history
  • Loading branch information
sandbergja authored Mar 1, 2024
1 parent 8658749 commit 7e44149
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ to the `<style>` section. You may also need `../assets/styles/spacing.scss` if
component uses spacing mixins. Media queries can't be included in CSS variables, so if you need those, import `../assets/styles/media_queries.scss` and use SCSS variables. There are functions that use SCSS variables and cannot take CSS variables as a parameter; In this case add `@import ../assets/styles/system.scss`.
1. Vue 3 no longer supports functional templates. If the component includes `<template functional>`,
you will need to refactor it back into a regular template.
1. If the component emits events, [declare the emits in the `emits` option](https://v3-migration.vuejs.org/breaking-changes/emits-option.html).
1. Run `npm run styleguide` and make sure it compiles and looks good.
1. Add the component to src/components/index.js so it is added to the lux Vue plugin and can be used in other projects.
1. Copy the test for the component from the lux test/unit/specs/components directory.
Expand Down

0 comments on commit 7e44149

Please sign in to comment.