-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drafts link to profile page #9837
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9837 +/- ##
=======================================
Coverage ? 79.59%
=======================================
Files ? 98
Lines ? 5964
Branches ? 0
=======================================
Hits ? 4747
Misses ? 1217
Partials ? 0 |
Hi @TildaDares - do you want to check the logs to see what failed here? It's extra helpful if you can paste the error into a comment, if you don't immediately see how to fix it i'm happy to help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super so far. Are you planning to add the link to point somewhere in this PR or in a follow-up? I did note possibly drafts_count
may not be entirely needed?
But great work, thanks Tilda!!!
The link will be in a follow-up PR. I'm still waiting on the PR for the author's notes template. |
Code Climate has analyzed commit ba8ac74 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Great job @TildaDares |
Great, thank you!!! |
Part of larger planning issue #9667
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below