Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drafts link to profile page #9837

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Add drafts link to profile page #9837

merged 1 commit into from
Jun 29, 2021

Conversation

TildaDares
Copy link
Member

Part of larger planning issue #9667

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshot 2021-06-22 at 12 16 20

@TildaDares TildaDares requested a review from a team as a code owner June 22, 2021 11:25
@gitpod-io
Copy link

gitpod-io bot commented Jun 22, 2021

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@596ff0c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ffd59d8 differs from pull request most recent head ba8ac74. Consider uploading reports for the commit ba8ac74 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9837   +/-   ##
=======================================
  Coverage        ?   79.59%           
=======================================
  Files           ?       98           
  Lines           ?     5964           
  Branches        ?        0           
=======================================
  Hits            ?     4747           
  Misses          ?     1217           
  Partials        ?        0           

@TildaDares TildaDares requested a review from jywarren June 22, 2021 11:53
@jywarren
Copy link
Member

Hi @TildaDares - do you want to check the logs to see what failed here? It's extra helpful if you can paste the error into a comment, if you don't immediately see how to fix it i'm happy to help!

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super so far. Are you planning to add the link to point somewhere in this PR or in a follow-up? I did note possibly drafts_count may not be entirely needed?

But great work, thanks Tilda!!!

app/models/user.rb Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
app/views/users/profile.html.erb Outdated Show resolved Hide resolved
test/unit/user_test.rb Show resolved Hide resolved
@TildaDares TildaDares closed this Jun 22, 2021
@TildaDares TildaDares reopened this Jun 22, 2021
@TildaDares
Copy link
Member Author

This looks super so far. Are you planning to add the link to point somewhere in this PR or in a follow-up?

The link will be in a follow-up PR. I'm still waiting on the PR for the author's notes template.

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2021

Code Climate has analyzed commit ba8ac74 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@RuthNjeri
Copy link
Contributor

Great job @TildaDares

@jywarren jywarren merged commit 78bf29f into publiclab:main Jun 29, 2021
@jywarren
Copy link
Member

Great, thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants