-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize presentation of results on tag pages (Research Notes) #9598
Conversation
Updated file config/locales/en.yml solved issue 9540
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit f0d0355 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9598 +/- ##
=======================================
Coverage ? 79.67%
=======================================
Files ? 98
Lines ? 5947
Branches ? 0
=======================================
Hits ? 4738
Misses ? 1209
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉
@TildaDares Are you going to Merge it ? |
@Guneetsinghtuli I'm not a reviewer |
Thanks, @Guneetsinghtuli, it looks good to me, do you mind adding a screenshot of what it looks like in the UI? |
@RuthNjeri I didn't set up the local environment, It was my first contribution so I did exactly what the instructions were given . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked the text and this looks good, thank you so much!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Updated file config/locales/en.yml solved issue 9540 Co-authored-by: GUNEET SINGH <[email protected]>
Updated file config/locales/en.yml solved issue 9540 Co-authored-by: GUNEET SINGH <[email protected]>
Updated file app/views/tag/show/_tab_content.html.erb
Updated file config/locales/en.yml
solved issue 9540
Fixes #9540
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!