Changed tag page 'No Results found' message

[TildaDares]

Fixes #9510 (<=== Add issue number here)

Before

Screen.Recording.2021-04-20.at.09.03.21.mov

After

Screen.Recording.2021-04-20.at.09.10.19.mov

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@44afb74). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9531   +/-   ##
=======================================
  Coverage        ?   81.49%           
=======================================
  Files           ?       98           
  Lines           ?     5924           
  Branches        ?        0           
=======================================
  Hits            ?     4828           
  Misses          ?     1096           
  Partials        ?        0           

[TildaDares]

I think I also need to change the tag params to other_tab in https://github.com/publiclab/plots2/blob/main/test/integration/I18n_test.rb#L426

[codeclimate]

Code Climate has analyzed commit cf3842f and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

Hi @TildaDares did you mean to close this? You can often continue to make changes and keep pushing them to the same remote branch and theyll keep showing up in the same PR. Just checking!

[TildaDares]

@jywarren I'll reopen it now. Thanks

[gitpod-io]

[TildaDares]

@jywarren Instead of using the en.yml to display the message, I think maybe we should just display the message here since each tab has it's own no_results found message.