Standardize presentation of results on tag pages (Research Notes) #9540

TildaDares · 2021-04-21T14:51:25Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file app/views/tag/show/_tab_content.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -7,8 +7,8 @@
   <% if @node_type == "note" %>
     <div class="tab-pane active" id="notes">
       <% if @notes.nil? || @notes.length == 0 %>
-        <p><%= raw translation('tag.show.no_results_found', tag: params[:id]) %>:</p>
-        <p><a href="/search/<%= params[:id] %>">Search for "<%= params[:id] %>"</a></p>
+        <p><%= raw translation('tag.show.no_notes_results_found') %></p>
+        <p>Or try searching: <a href="/search/<%= params[:id] %>"><%= params[:id] %></a></p>
       <% else %>
         <%= render partial: "notes/notes", locals: { tagname: params[:id] } %>
       <% end %>

📝 Update the file config/locales/en.yml in the plots2 repository (press the little pen Icon) and edit the line as shown below.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -466,6 +466,7 @@ en:
       wiki_pages: "Wiki pages"
       maps: "Maps"
       no_results_found: "No results found; try searching for '<b>%{tag}</b>'"
+      no_notes_results_found: "Hi! No Research Notes have this tag <span>&#x1F937</span>, try checking the <b>Questions</b> or <b>Wiki</b> tabs on this page."
       try_advanced_search: "Or try an <a href='%{url1}'>advanced search</a>"
       people: "People"
       no_map_results_found: "Sorry, no map is tagged with <i>%{tag}</i>"

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

The text was updated successfully, but these errors were encountered:

TildaDares · 2021-04-21T14:52:37Z

@cesswairimu I'm breaking up the tasks in #9510. Are these changes okay?

TildaDares · 2021-04-21T14:59:39Z

@xdshivani I'm waiting on a reviewer to approve this and when they do you can work on it.

TildaDares · 2021-04-22T19:00:46Z

@RuthNjeri Can you approve this?

RuthNjeri · 2021-04-22T19:56:20Z

Thanks for opening this up @TildaDares,
For the texts, we encourage using the translation method and adding the text in the en.yml file... have a look at this example issue.. #9249

RuthNjeri · 2021-04-22T20:00:29Z

Once you update it to used the translation method and have the text within the en.yml, the issue should be good to go 🚀

TildaDares · 2021-04-23T09:44:47Z

@RuthNjeri I've made the changes. I'm still going to have to create another issue to replace the files that use tag.show.no_results_found

RuthNjeri · 2021-04-23T14:34:48Z

@TildaDares can that replacement also be done by this issue? I am concerned that if there are files using the old tag.show.no_results_found and it is removed, we might not display the correct content for the users as we wait for those files to be updated...

Alternatively, we could keep the previous no_results_found and have the notes one as notes_no_results_found then after all the changes have been made, we can update the en.yml file with the nesting you have specified for the notes, wiki, or even questions in the future...

What do you think?

TildaDares · 2021-04-23T15:13:38Z

@RuthNjeri I think the second option is better. This way we don't have to change code that uses no_results_found.

TildaDares · 2021-04-23T17:16:09Z

@RuthNjeri I've made the changes.

RuthNjeri · 2021-04-23T18:38:48Z

Thanks, @TildaDares, I think anyone interested can pick it up...

For the emoji on the text, is there a text/symbol for that emoji? Since it will be on a text file and rendered by the HTML tag

TildaDares · 2021-04-23T19:06:14Z

@RuthNjeri I'll change that now.

TildaDares · 2021-04-23T19:15:42Z

@xdshivani Do you still want to work on this?

cesswairimu · 2021-04-24T08:53:33Z

Thanks a lot @TildaDares for opening this 🎉

TildaDares · 2021-04-25T17:11:30Z

@DR-FREKE You can work on this.

DR-FREKE · 2021-04-25T18:21:14Z

@TildaDares okay

DR-FREKE · 2021-04-25T18:42:03Z

@TildaDares @cesswairimu just made a pull request on this

cesswairimu · 2021-04-27T08:19:41Z

Hi @DR-FREKE , I see you already made a first-timer contribution #9550, do you mind leaving this to a first-timer?

jywarren · 2021-04-27T15:18:19Z

This looks awesome folks, thanks so much to @TildaDares and to everyone who's supporting!

Guneetsinghtuli · 2021-05-04T16:08:02Z

Hi @cesswairimu @jywarren I would like to work on this issue #9540 , Can you assign this to me ?

TildaDares · 2021-05-04T16:46:44Z

@Guneetsinghtuli Go ahead🎉

Guneetsinghtuli · 2021-05-05T08:21:54Z

@TildaDares @cesswairimu I have made a pull request please have a look and let me know if there are any changes

TildaDares added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Apr 21, 2021

cesswairimu mentioned this issue May 4, 2021

Request & make "first-timer-only" issues for newcomers #9083

Closed

61 tasks

Guneetsinghtuli mentioned this issue May 5, 2021

Standardize presentation of results on tag pages (Research Notes) #9598

Merged

5 tasks

jywarren mentioned this issue May 11, 2021

Standardize presentation of "no results" messages on tag page tabs #9510

Closed

jywarren closed this as completed in #9598 May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standardize presentation of results on tag pages (Research Notes) #9540

Standardize presentation of results on tag pages (Research Notes) #9540

TildaDares commented Apr 21, 2021 •

edited

Loading

TildaDares commented Apr 21, 2021

TildaDares commented Apr 21, 2021

TildaDares commented Apr 22, 2021

RuthNjeri commented Apr 22, 2021 •

edited

Loading

RuthNjeri commented Apr 22, 2021

TildaDares commented Apr 23, 2021

RuthNjeri commented Apr 23, 2021 •

edited

Loading

TildaDares commented Apr 23, 2021 •

edited

Loading

TildaDares commented Apr 23, 2021

RuthNjeri commented Apr 23, 2021

TildaDares commented Apr 23, 2021

TildaDares commented Apr 23, 2021

cesswairimu commented Apr 24, 2021 •

edited

Loading

TildaDares commented Apr 25, 2021

DR-FREKE commented Apr 25, 2021

DR-FREKE commented Apr 25, 2021

cesswairimu commented Apr 27, 2021

jywarren commented Apr 27, 2021

Guneetsinghtuli commented May 4, 2021

TildaDares commented May 4, 2021

Guneetsinghtuli commented May 5, 2021

Standardize presentation of results on tag pages (Research Notes) #9540

Standardize presentation of results on tag pages (Research Notes) #9540

Comments

TildaDares commented Apr 21, 2021 • edited Loading

🤔 What you will need to know.

📋 Step by Step

Please keep us updated

Is someone else already working on this?

🤔❓ Questions?

TildaDares commented Apr 21, 2021

TildaDares commented Apr 21, 2021

TildaDares commented Apr 22, 2021

RuthNjeri commented Apr 22, 2021 • edited Loading

RuthNjeri commented Apr 22, 2021

TildaDares commented Apr 23, 2021

RuthNjeri commented Apr 23, 2021 • edited Loading

TildaDares commented Apr 23, 2021 • edited Loading

TildaDares commented Apr 23, 2021

RuthNjeri commented Apr 23, 2021

TildaDares commented Apr 23, 2021

TildaDares commented Apr 23, 2021

cesswairimu commented Apr 24, 2021 • edited Loading

TildaDares commented Apr 25, 2021

DR-FREKE commented Apr 25, 2021

DR-FREKE commented Apr 25, 2021

cesswairimu commented Apr 27, 2021

jywarren commented Apr 27, 2021

Guneetsinghtuli commented May 4, 2021

TildaDares commented May 4, 2021

Guneetsinghtuli commented May 5, 2021

TildaDares commented Apr 21, 2021 •

edited

Loading

RuthNjeri commented Apr 22, 2021 •

edited

Loading

RuthNjeri commented Apr 23, 2021 •

edited

Loading

TildaDares commented Apr 23, 2021 •

edited

Loading

cesswairimu commented Apr 24, 2021 •

edited

Loading