-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Caddy webserver configuration and tutorial on Caddy with Cloudflare DNS in proxy mode #535
Conversation
…dy with Cloudflare DNS in proxy mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use spaces instead of tabs? As all other snippits do
I have changed the tabs to spaces (editor default) in the snippets. Please, consider adding an cc @PadowYT2 |
Hi, the PR is getting really stale. Can you @PadowYT2 do the code review and approve/request changes/close this PR? Thanks! Perhaps @parkervcp, you have closed #384 in favour of this PR, can you make this PR move? |
I'm not a maintainer sadly |
@PadowYT2 oh, I did not know that. That's unfortunate. @parkervcp can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used Caddy, please correct me if I'm wrong
…ly restart the daemon
@PadowYT2 I've pushed a new version, resolving the last conversation. Feel free to review the PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…archy - this was required to allow for `::: tip :::` inside a tab. Using only three colons resulted in formatting/rendering error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more things needs to be edited
…change domain in caddy config after deleting default config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe only these are the final changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@parkervcp I wish you merry Christmas! Also, can you have a look at this PR and review it and perhaps merge it? Thanks! |
I'm on vacation and will be available to review this on the 27th. |
Hi, thanks for the approval. Is there anything I can do? How can I get this merged? Thanks! |
No description provided.