-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch RSG to ProtoPromise. #226
Conversation
f7a86ff
to
8a59368
Compare
@jdnichollsc I just updated this PR with the latest version of ProtoPromise, and I re-implemented the Promise requests more efficiently. PTAL |
…ines. Replaced RSG with ProtoPromise in demo. Updated readme.
Hi @timcassell do you have a unity package for your implementation? Tried to replace folders in the RestClient folder and got errors in the editor. |
@kapyar What errors? Do you have ProtoPromise installed? |
@timcassell Hi! Thanks for your work. How can i install this branch? |
a54ed89
to
a1da561
Compare
@HajiyevEl First, install ProtoPromise (instructions), then install this branch via git url in the Package Manager.
@kapyar I also fixed your issue by adding the assembly reference. |
Closed because this project is apparently dead, and I have removed support for .Net 3.5 in ProtoPromise. If there is any interest from the maintainers to update this project, I will be happy to help. |
Resolves #216 and resolves #107.
@jdnichollsc I am not sure how your package build system works, so I only updated the src and demo. Feel free to edit my branch or give feedback for me to change other parts.
Also, since this will be a breaking change, the release version should probably be updated to 3.0.0 if this is accepted.