Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit: fix deprecation warnings #2022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function testObjectAttributes()
{
$expectedAttributes = ['nestedSetQueries'];
foreach ($expectedAttributes as $attribute) {
$this->assertClassHasAttribute($attribute, 'NestedSetTable9');
$this->assertTrue(property_exists('NestedSetTable9', $attribute));
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ protected function checkClassHasValidateBehavior($class)
$this->assertTrue(method_exists($class, 'validate'), "Class $class has no validate() method");
$this->assertTrue(method_exists($class, 'getValidationFailures'), "Class $class has no getValidationFailures() method");
$this->assertTrue(method_exists($class, 'loadValidatorMetadata'), "Class $class has no loadValidatorMetadata() method");
$this->assertClassHasAttribute('alreadyInValidation', $class, "Class $class has no 'alreadyInValidation' property");
$this->assertClassHasAttribute('validationFailures', $class, "Class $class has no 'validationFailures' property");
$this->assertTrue(property_exists($class, 'alreadyInValidation'), "Class $class has no 'alreadyInValidation' property");
$this->assertTrue(property_exists($class, 'validationFailures'), "Class $class has no 'validationFailures' property");
$method = new ReflectionMethod($class, 'loadValidatorMetadata');
$this->assertTrue($method->isStatic(), "Method loadValidatorMetadata() of class $class isn't static");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function testHasLoadValidatorMetadataMethod()
public function testHasAlreadyInValidationAttribute()
{
foreach ($this->classes as $class) {
$this->assertClassHasAttribute('alreadyInValidation', $class);
$this->assertTrue(property_exists($class, 'alreadyInValidation'));
}
}

Expand All @@ -89,7 +89,7 @@ public function testHasAlreadyInValidationAttribute()
public function testHasValidationFailuresAttribute()
{
foreach ($this->classes as $class) {
$this->assertClassHasAttribute('validationFailures', $class);
$this->assertTrue(property_exists($class, 'validationFailures'));
}
}

Expand Down
Loading