Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New one-click preview page [0XP-1662] #2131

Merged
merged 12 commits into from
Nov 8, 2024
Merged

New one-click preview page [0XP-1662] #2131

merged 12 commits into from
Nov 8, 2024

Conversation

17Amir17
Copy link
Collaborator

@17Amir17 17Amir17 commented Nov 7, 2024

Screen.Recording.2024-11-07.at.17.35.28.mov

Copy link

linear bot commented Nov 7, 2024

Copy link
Collaborator

@rrrliu rrrliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button does not match the button on the figma

Screenshot 2024-11-07 at 9 39 33 PM

@rrrliu
Copy link
Collaborator

rrrliu commented Nov 7, 2024

also, where are the QR codes in this implementation?

@rrrliu
Copy link
Collaborator

rrrliu commented Nov 7, 2024

also, where are the QR codes in this implementation?

i see that the qrCodeOverrideImageUrl has probably been set here

@rrrliu rrrliu merged commit c989ade into main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants