Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert add avgRTT to nfs mountstats #487 #625

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Mar 28, 2024

This is an artificiality computed value from existing values. The goal of this library is to provide simple raw access to values, rather than pre-compute data.

Reverts: #487

This is an artificiality computed value from existing values. The goal
of this library is to provide simple raw access to values, rather than
pre-compute data.

Reverts: #487

Signed-off-by: SuperQ <[email protected]>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

I'm not sure why I'm tagged here, I haven't worked on this library before 😬
Looking at #629 I can see you were made a maintainer, so I believe you know what you're doing :) Giving the rubber stamp just in case you need someone to unblock the PR

Unfortunately, I won't have the time to fully understand the impact of this revert, I suggest that other maintainers chime in if you're looking for a longer discussion!

@SuperQ SuperQ merged commit 5819c81 into master Apr 5, 2024
10 checks passed
@SuperQ SuperQ deleted the superq/revert487 branch April 5, 2024 15:44
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Apr 23, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs)
| `v0.13.0` -> `v0.14.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fprocfs/v0.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fprocfs/v0.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fprocfs/v0.13.0/v0.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fprocfs/v0.13.0/v0.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>prometheus/procfs (github.com/prometheus/procfs)</summary>

###
[`v0.14.0`](https://togithub.com/prometheus/procfs/releases/tag/v0.14.0)

[Compare
Source](https://togithub.com/prometheus/procfs/compare/v0.13.0...v0.14.0)

#### What's Changed

- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/procfs/pull/613](https://togithub.com/prometheus/procfs/pull/613)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/procfs/pull/615](https://togithub.com/prometheus/procfs/pull/615)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/procfs/pull/616](https://togithub.com/prometheus/procfs/pull/616)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/procfs/pull/621](https://togithub.com/prometheus/procfs/pull/621)
- Revert add avgRTT to nfs mountstats
[#&#8203;487](https://togithub.com/prometheus/procfs/issues/487) by
[@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/procfs/pull/625](https://togithub.com/prometheus/procfs/pull/625)
- style: returns procfs build-in error like other parsing methods by
[@&#8203;weidongkl](https://togithub.com/weidongkl) in
[https://github.com/prometheus/procfs/pull/630](https://togithub.com/prometheus/procfs/pull/630)
- update MAINTAINERS.md by [@&#8203;pgier](https://togithub.com/pgier)
in
[https://github.com/prometheus/procfs/pull/629](https://togithub.com/prometheus/procfs/pull/629)
- \*: `s/(%v|%s)/%w` and use `go1.20` by
[@&#8203;rexagod](https://togithub.com/rexagod) in
[https://github.com/prometheus/procfs/pull/617](https://togithub.com/prometheus/procfs/pull/617)
- chore: Use kernel-compliant types for `{U,G}IDs` by
[@&#8203;rexagod](https://togithub.com/rexagod) in
[https://github.com/prometheus/procfs/pull/620](https://togithub.com/prometheus/procfs/pull/620)
- Update Go versions by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/procfs/pull/632](https://togithub.com/prometheus/procfs/pull/632)
- fix: same TCP connection appears twice by
[@&#8203;weidongkl](https://togithub.com/weidongkl) in
[https://github.com/prometheus/procfs/pull/631](https://togithub.com/prometheus/procfs/pull/631)
- Revert "fix: same TCP connection appears twice" by
[@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/procfs/pull/633](https://togithub.com/prometheus/procfs/pull/633)

#### New Contributors

- [@&#8203;rexagod](https://togithub.com/rexagod) made their first
contribution in
[https://github.com/prometheus/procfs/pull/617](https://togithub.com/prometheus/procfs/pull/617)

**Full Changelog**:
prometheus/procfs@v0.13.0...v0.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
This is an artificiality computed value from existing values. The goal
of this library is to provide simple raw access to values, rather than
pre-compute data.

Reverts: prometheus#487

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants