Skip to content

Commit

Permalink
Revert add avgRTT to nfs mountstats #487
Browse files Browse the repository at this point in the history
This is an artificiality computed value from existing values. The goal
of this library is to provide simple raw access to values, rather than
pre-compute data.

Reverts: #487

Signed-off-by: SuperQ <[email protected]>
  • Loading branch information
SuperQ committed Mar 28, 2024
1 parent c5ada8d commit 8e96ca0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
5 changes: 0 additions & 5 deletions mountstats.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ type NFSOperationStats struct {
CumulativeTotalResponseMilliseconds uint64
// Duration from when a request was enqueued to when it was completely handled.
CumulativeTotalRequestMilliseconds uint64
// The average time from the point the client sends RPC requests until it receives the response.
AverageRTTMilliseconds float64
// The count of operations that complete with tk_status < 0. These statuses usually indicate error conditions.
Errors uint64
}
Expand Down Expand Up @@ -582,9 +580,6 @@ func parseNFSOperationStats(s *bufio.Scanner) ([]NFSOperationStats, error) {
CumulativeTotalResponseMilliseconds: ns[6],
CumulativeTotalRequestMilliseconds: ns[7],
}
if ns[0] != 0 {
opStats.AverageRTTMilliseconds = float64(ns[6]) / float64(ns[0])
}

if len(ns) > 8 {
opStats.Errors = ns[8]
Expand Down
3 changes: 0 additions & 3 deletions mountstats_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 6,
CumulativeTotalResponseMilliseconds: 79386,
CumulativeTotalRequestMilliseconds: 79407,
AverageRTTMilliseconds: 61.16024653312789,
},
{
Operation: "WRITE",
Expand All @@ -353,7 +352,6 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 18446743919241604546,
CumulativeTotalResponseMilliseconds: 1667369447,
CumulativeTotalRequestMilliseconds: 1953587717,
AverageRTTMilliseconds: 0.5695744656983355,
},
},
Transport: NFSTransportStats{
Expand Down Expand Up @@ -427,7 +425,6 @@ func TestMountStats(t *testing.T) {
CumulativeQueueMilliseconds: 320,
CumulativeTotalResponseMilliseconds: 11,
CumulativeTotalRequestMilliseconds: 331,
AverageRTTMilliseconds: 0.6875,
Errors: 0,
},
},
Expand Down

0 comments on commit 8e96ca0

Please sign in to comment.