Update procfs to 0.15.1 and fix compilation errors #3045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
|
Looks like there are more issues to fix. |
Signed-off-by: Peter Štibraný <[email protected]>
There was problem caused by change in prometheus/procfs#619. PTAL at my proposed workaround (see description). |
SuperQ
reviewed
Jun 10, 2024
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // lastTransportOrEmpty returns last element from given slice. Before https://github.com/prometheus/procfs/issues/450, |
There was a problem hiding this comment.
Hmm, I wonder if we should handle this better, now that we have all the data.
There was a problem hiding this comment.
Better would be to export each stat individually, but we would need some new label for that -- perhaps "port"?
There was a problem hiding this comment.
PTAL at 5237827, where I've added port label to transport-metrics.
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
|
This needs rebasing |
|
This was fixed in #3059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates procfs to 0.15.1, and fixes compilation errors due to breaking change in prometheus/procfs#623.
Another change that caused compilation problems was prometheus/procfs#619 (issue prometheus/procfs#450). This introduced multiple transport stats per NFS mount.
This PR keeps reporting last stats only, which I believe was the case before prometheus/procfs#619 was merged. Alternative would be to export all transport stats, or perhaps aggregate values together (not sure if that makes sense).Update: This PR now reports transport stats for each local port individually.
Replaces #3037.