Fix broken rules with Prometheus v3 #2575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Prometheus v3 [histograms are normalized](https://prometheus.io/docs/prometheus/latest/migration/#le-and-quantile-label-values) and this breaks rules that select on the `le` label. This PR overwrites the label selectors that [mixin](https://github.com/kubernetes-monitoring) usese. Before: ``` {le="1"} ``` Now with Prometheus v3: ``` {le="1.0"} ``` This will break set ups with prometheus v2. However, I think it is still an improvement by default Prometheus v3 is used and I would expect that the generated rules are workind with the default Prometheus version as well. Fixes prometheus-operator#2573 Signed-off-by: leonnicolas <[email protected]>
|
the rules were updated upstream in kubernetes-monitoring/kubernetes-mixin#1008. So maybe we can just bump a version and close this PR EDIT: created a PR to bump kubernetes-mixin version #2580 |
leonnicolas
added a commit
to leonnicolas/kube-prometheus
that referenced
this pull request
Jan 2, 2025
Update jsonnet packages. The resulting changes come from the update of https://github.com/kubernetes-monitoring/kubernetes-mixin. Most importantly it contains an update to fix prometheus recoding rules that were broken for prometheus v3. This would close prometheus-operator#2575
|
fixed by #2581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Prometheus v3 histograms are normalized and this breaks rules that
select on the
lelabel.This PR overwrites the label selectors that
mixin usese.
Before:
Now with Prometheus v3:
This will break set ups with prometheus v2.
However, I think it is still an improvement by default Prometheus v3 is
used and I would expect that the generated rules are workind with the
default Prometheus version as well.
Fixes #2573
Signed-off-by: leonnicolas [email protected]