Skip to content

Commit

Permalink
Synchronize common files from prometheus/prometheus (#242)
Browse files Browse the repository at this point in the history
* Update common Prometheus files

Signed-off-by: prombot <[email protected]>

* chore: fix lint issue

Signed-off-by: Simon Pasquier <[email protected]>

---------

Signed-off-by: prombot <[email protected]>
Signed-off-by: Simon Pasquier <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
  • Loading branch information
prombot and simonpasquier authored Aug 20, 2024
1 parent eed8f74 commit 6a810d3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
with:
args: --verbose
version: v1.59.1
version: v1.60.1
2 changes: 1 addition & 1 deletion Makefile.common
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ PROMU_URL := https://github.com/prometheus/promu/releases/download/v$(PROMU_
SKIP_GOLANGCI_LINT :=
GOLANGCI_LINT :=
GOLANGCI_LINT_OPTS ?=
GOLANGCI_LINT_VERSION ?= v1.59.1
GOLANGCI_LINT_VERSION ?= v1.60.1
# golangci-lint only supports linux, darwin and windows platforms on i386/amd64/arm64.
# windows isn't included here because of the path separator being different.
ifeq ($(GOHOSTOS),$(filter $(GOHOSTOS),linux darwin))
Expand Down
2 changes: 1 addition & 1 deletion injectproxy/silences_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ func TestDeleteSilence(t *testing.T) {
t.Fatalf("unexpected error: %v", err)
}

u, err := url.Parse(fmt.Sprintf("http://alertmanager.example.com/api/v2/silence/" + tc.ID))
u, err := url.Parse(fmt.Sprintf("http://alertmanager.example.com/api/v2/silence/%s", tc.ID))
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
Expand Down

0 comments on commit 6a810d3

Please sign in to comment.