Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(primitives): transition to new css primitives #338

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ci(primitives): transition to new css primitives #338

wants to merge 2 commits into from

Commits on Aug 14, 2024

  1. ci(primitives): transition to new css primitives 

    GitHub no longer distributes primitives in JSON format. Also, the names
of the values (i.e. CSS variables) have changed. Most of the new names
correspond 1-to-1 with one of the old names. Some colors have also
changed slightly (e.g. `fg-default`), but otherwise remain mostly the
same. See https://primer.style/foundations/primitives/migrating.

Source color primitives from `@primer/primitives/dist/internalCss`
instead of `@primer/primitives/dist/css/functional/themes` as only the
former directory contains the base colors (scales).

Convert new primer css primitives/variables directly to lua in
.github/workflows/csstolua.lua (runs in CI). This script generates some
debugging info in case an error occurs (which can be found in CI logs).
Convert to a nested table structure for idiomatic usage in lua. The
primitives table now provides type-hints via lsp, and accessing invalid
names at runtime will throw an error. Append `.default` to
names/keypaths which are too short and would otherwise collide with
existing tables.

- `scale` no longer exists, but is still provided (by us) for
  backwards-compatibility and ergonomics. The new names are in the
  format of `base.color.red[4]` (for example to access `scale.red[5]`).
  The values in `scale` are 1-indexed for lua, but the original upstream
  names (in `base.color.*`) are 0-indexed and left untouched.

- `scale.gray` no longer exists, use `scale.neutral` in its place

- `*.subtle` variants no longer exist, see the link above for the
  corresponding replacements
    @tmillr
    tmillr committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c263e7c View commit details
    Browse the repository at this point in the history

  2. deps(primer): update primitives

    @tmillr
    tmillr committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7972004 View commit details
    Browse the repository at this point in the history