Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(palette): get canvas from primitives #299

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

tmillr
Copy link
Member

@tmillr tmillr commented Sep 21, 2023

This should also correct any issues with the Normal bg being off or incorrect, as this color (i.e. the Normal bg, the global bg) ultimately derives from canvas.default (found in the palette).

Fixes #298

This should also correct any issues with the `Normal` bg being off or
incorrect, as this color (i.e. the `Normal` bg, the global bg)
ultimately derives from `canvas.default` (found in the palette).

Fixes projekt0n#298
@tmillr tmillr marked this pull request as ready for review September 21, 2023 04:57
@NikoKS
Copy link

NikoKS commented Oct 24, 2023

@ful1e5, Hello, is it possible to merge this fix?

@luisdavim
Copy link
Contributor

Any reason not to merge this?

@ful1e5
Copy link
Member

ful1e5 commented Nov 20, 2023

@luisdavim I'm busy with another project. I'll merge this pull request soon.

@ful1e5 ful1e5 merged commit f2de78a into projekt0n:main Nov 26, 2023
17 checks passed
@tmillr tmillr deleted the fix-298 branch June 27, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any colorscheme that looks like github code viewer?
4 participants