Add support for bootstrapping additional root apps #158
+98
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
simu
force-pushed
the
feat/additional-root-apps
branch
2 times, most recently
from
096b628 to
00820cc
Compare
5 tasks
simu
force-pushed
the
feat/additional-root-apps
branch
from
00820cc to
61f1d23
Compare
See [SDD-0030 - ArgoCD multitenancy] for the overall design for additional root apps. This commit introduces a new command line flag to specify a config map from which Steward will read field `teams` which is expected to contain a JSON-encoded list of team names for which to setup additional ArgoCD AppProject and root Application (app of apps) resources. Steward uses the team names as is for the additional AppProject resources, and creates the additional root apps as `root-<team name>`. As defined in the design document, the path for the root apps is configured as `manifests/apps-<team name>/`. The new code is added to `argocd.Apply()` before the short-circuit which exits the function if an ArgoCD custom resource is present on the cluster already. [SDD-0030 - ArgoCD multitenancy]: https://syn.tools/syn/SDDs/0030-argocd-multitenancy.html
simu
force-pushed
the
feat/additional-root-apps
branch
from
61f1d23 to
28f2878
Compare
Return silently if an AppProject or Application with the requested name already exists.
|
See projectsyn/documentation#182 for documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SDD-0030 - ArgoCD multitenancy for the overall design for additional root apps.
This commit introduces a new command line flag to specify a config map name from which Steward will read a JSON-encoded list of team names for which to setup additional ArgoCD AppProject and root Application (app of apps) resources.
Steward uses the team names as is for the additional AppProject resources, and creates the additional root apps as
root-<team name>. As defined in the design document, the path for the root apps is configured asmanifests/apps-<team name>/.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog