Specify the Lieutenant API Url in an argument to the operator #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyTetrahedron
force-pushed
the
feat/specify-api-url
branch
from
7bd660a to
083a34b
Compare
| @@ -18,6 +18,7 @@ parameters: | |||
| operator: | |||
| manifest_version: v${lieutenant:images:operator:version} | |||
| manifest_url: https://raw.githubusercontent.com/projectsyn/lieutenant-operator/${lieutenant:operator:manifest_version}/config | |||
| lieutenant_api_url: https://${lieutenant:api:ingress:host} | |||
There was a problem hiding this comment.
Is this ever different than ${lieutenant:api:ingress:host}?
If not, than you could compute the value of the ENV varibale from the api ingress config.
There was a problem hiding this comment.
Probably not. It still felt iffy to hardcode it.
DebakelOrakel
approved these changes
Jul 26, 2024
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires lieutenant-operator v1.11 to be released
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.