Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch SourceTypeConverter to avoid parsing empty strings #3749

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Patch SourceTypeConverter to avoid parsing empty strings #3749

merged 1 commit into from
Oct 17, 2024

Conversation

Rawi01
Copy link
Collaborator

@Rawi01 Rawi01 commented Sep 19, 2024

This PR fixes #3748

@rzwitserloot rzwitserloot merged commit 1ac535f into projectlombok:master Oct 17, 2024
55 of 57 checks passed
@rzwitserloot
Copy link
Collaborator

Ha! That trick of replacing assertTrue(list.isEmpty()) with assertEquals(Collections.emptyList(), list) is, I presume, so that if the assertion fails, the JUnit IDE renderer thingie will show you the non-empty list, instead of simply telling you: This assertion failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] @Synchronized causes error markers in Java editor with Eclipse 2024-09 (4.33.0)
2 participants
@Rawi01 @rzwitserloot