Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Support complex DOM trees in overlays #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

React: Support complex DOM trees in overlays #621

wants to merge 1 commit into from

Conversation

nitn3lav
Copy link

Because:

  • Sometimes, the line between UI localization and content localization is thin. There are cases in which we should allow localizing longer, structured text with nested overlays. See Support complex DOM trees in overlays #288

This PR:

  • Adds a prop, nestedElems, to LocalizedProps and an arg, arg.nestedElems, to Localized.getElement() that allows consumers to opt-in to recursively parse nested elements in overlays. By default this is disabled.

@nitn3lav
feat(react): Support complex DOM trees in overlays (projectfluent#288)
0f1b88b 
    Because:

    * Sometimes, the line between UI localization and content localization
	  is thin. There are cases in which we should allow localizing longer,
	  structured text with nested overlays.

    This commit:

	* Adds a prop, nestedElems, to LocalizedProps and an arg, arg.nestedElems,
	  to Localized.getElement() that allows consumers to opt-in to
	  recursively parse nested elements in overlays. By default this is
	  disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nitn3lav