Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release 'safe harbor' versions of Fluent workspace crates #349

Merged
merged 1 commit into from
May 5, 2024

Conversation

alerque
Copy link
Collaborator

@alerque alerque commented Mar 15, 2024

These releases serve as a markers in the transition from the Project Fluent related crates being a wholly Mozilla managed project to bringing on non-Mozilla community maintainers. The safe harbor release series publishes the current Git HEAD of all crates as a convenience to downstream consumers that either audit the code and contributors, don't want to adopt potential changes for whatever reason, or just want an easy reference point against which to compare future releases.

Closes #347


Related issues:

These releases serve as a markers in the transition from the Project
Fluent related crates being a wholly Mozilla managed project to bringing
on non-Mozilla community maintainers. The safe harbor release series
publishes the current Git HEAD of all crates as a convenience to
downstream consumers that either audit the code and contributors, don't
want to adopt potential changes for whatever reason, or just want an
easy reference point against which to compare future releases.
@alerque
Copy link
Collaborator Author

alerque commented Mar 15, 2024

@zbraniecki Similar to my comment on the matching fluent-langneg PR I think it would make a lot of sense for you to do some combination of amending this commit to be the author, adding a signoff, and/or doing the final publish to crates.io. Your name is already on many/most of the releases to date so having it there again seems like the clearest signal to give end users clear expectations.

Likewise I set this to draft mode pending any input folks have on whether to add myself and @waywardmorkeys to the authors field as an even more explicit signal an what to expect from future releases.

@alerque alerque requested a review from zbraniecki March 15, 2024 09:40
@alerque
Copy link
Collaborator Author

alerque commented Mar 18, 2024

Since nobody seems inclined to comment on the authors issue, my inclination is to just leave it alone and keep the safe-harbor commit as minimal as possible, then change the meta data as soon as we actually start doing something. I'll put it in my pending meta-data cleanup PR (#348).

And with that, I'll take his out of draft mode. I've done some testing and semver checks and everything I've seen suggests this can get merged and published to crates.io.

@alerque alerque marked this pull request as ready for review March 18, 2024 12:36
@gregtatum gregtatum self-requested a review March 20, 2024 18:59
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable to me! Thanks for taking the time to do it.

@zbraniecki zbraniecki merged commit 74020c3 into main May 5, 2024
5 checks passed
@alerque alerque deleted the safe-harbor branch May 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does a 'safe harbor' release of the current HEAD make sense before further changes?
3 participants