Fixed up clippy warnrings/errors #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
approved these changes
Nov 21, 2022
| @@ -120,6 +120,12 @@ impl PartialEq for ResourceId { | |||
| } | |||
| } | |||
|
|
|||
| impl std::hash::Hash for ResourceId { | |||
There was a problem hiding this comment.
Thought (no action needed): Ah, I'm trying to reason through this, but it seems like we may have some correctness issues around handling multiple resources that have different optional values. Previously the behavior looks like you could add multiple ResourceId values with differing ResourceTypes, but now it will only have one. I'm not sure what the correct resolution is here, or if anything needs to happen. Maybe I should add some tests around this area.
This seems like a low-probability edge case, but should probably be reasoned through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up clippy warnings/errors before working on #287
For reference:
PartialEq, Eq: https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eqDerived
Hashwithimpl PartialEq: https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq