-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(helm): make capsule configuration name configurable via helm #1103
Conversation
✅ Deploy Preview for capsule-documentation canceled.
|
LGTM, may I ask you to amend the commits with the DCO and change the Pull Request title to Thanks! |
Signed-off-by: Daniel S. <[email protected]>
Signed-off-by: Daniel S. <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
I tried to, but this DCO ... seems to make trouble? I'm lost here, sorry. |
Hi @sybnex I got the problem, and I fixed. JFI The current version of the DCO uses a version of Git that removed the dot ( Thanks |
Hi @sybnex, may I ask you to update the chart documentation? +| manager.options.capsuleConfiguration | string | `"default"` | Change the default name of the capsule configuration name | You should be able to do it just by running Overall LGTM |
As this is fixed in the helm templates we need a very hacky implementation to change this value.
We have like 150 groups which we are creating in a new configuration.
So I suggest to make this configuration templated as well.