Skip to content

Commit

Permalink
chore: fix some comments (#1146)
Browse files Browse the repository at this point in the history
Signed-off-by: beforetech <[email protected]>
Co-authored-by: Dario Tranchitella <[email protected]>
  • Loading branch information
beforetech and prometherion authored Aug 1, 2024
1 parent 9af5913 commit eb7a77a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ git clone https://hostname/YOUR-USERNAME/YOUR-REPOSITORY

2. **Create a branch:**

Create a new brach and navigate to the branch using this command.
Create a new branch and navigate to it using this command.

```sh
git checkout -b <new-branch>
Expand Down Expand Up @@ -180,7 +180,7 @@ The semantics should indicate the change and it's impact. The general format for
The following types are allowed for commits and pull requests:

* `chore`: housekeeping changes, no production code change
* `ci`: changes to buillding process/workflows
* `ci`: changes to building process/workflows
* `docs`: changes to documentation
* `feat`: new features
* `fix`: bug fixes
Expand Down
2 changes: 1 addition & 1 deletion docs/content/guides/rancher-projects/capsule-rancher.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ When onboarding tenants, the administrator needs to create the following, in ord

#### Create the Tenant Member Project Role

A custom `Project Role` is needed to allow Tenant users, with minimun set of privileges and create and delete `Namespace`s.
A custom `Project Role` is needed to allow Tenant users, with minimum set of privileges and create and delete `Namespace`s.

Create a Project Role named *Tenant Member* that inherits the privileges from the following Roles:
- *read-only*
Expand Down
2 changes: 1 addition & 1 deletion e2e/ingress_class_networking_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ var _ = Describe("when Tenant handles Ingress classes with networking.k8s.io/v1"
Expect(*i.Spec.IngressClassName).To(Equal(class.GetName()))
})

It("shoult mutate to default tenant IngressClass although the cluster global one is not allowed", func() {
It("should mutate to default tenant IngressClass although the cluster global one is not allowed", func() {
if err := k8sClient.List(context.Background(), &networkingv1.IngressList{}); err != nil {
if utils.IsUnsupportedAPI(err) {
Skip(fmt.Sprintf("Running test due to unsupported API kind: %s", err.Error()))
Expand Down

0 comments on commit eb7a77a

Please sign in to comment.