Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure embed components for testing. #3163

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Configure embed components for testing. #3163

wants to merge 5 commits into from

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Sep 27, 2024

No description provided.

@@ -123,7 +123,7 @@ def blacklight_config
config.view.embed!
# This is blacklight-gallery's openseadragon partial
unless config.view.embed.document_component
config.view.embed.partials ||= ['openseadragon']
config.view.embed.partials ||= ['openseadragon'] unless config.view.embed.embed_component
Copy link
Member

@jcoyne jcoyne Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put something in the CatalogController template that shows the usage of embed_component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Some future version of the blacklight_gallery:install generator will do that.

@cbeer cbeer force-pushed the embed-components branch 2 times, most recently from 7ed831c to 8951982 Compare September 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants